[cfe-commits] r59604 - /cfe/trunk/lib/Parse/ParseObjc.cpp
daniel at zuster.org
Wed Nov 19 21:28:59 PST 2008
Its not particularly confusing, but it looks wrong at a glance. Does
SmallString not have a constructor to initialize from a const char*?
On Wed, Nov 19, 2008 at 9:12 PM, Chris Lattner <sabre at nondot.org> wrote:
> On Nov 19, 2008, at 2:25 AM, Daniel Dunbar wrote:
>> On Tue, Nov 18, 2008 at 11:41 PM, Chris Lattner <sabre at nondot.org> wrote:
>>> + llvm::SmallString<100> SelectorName;
>>> + SelectorName += "set";
>> This '+=' is confusing, '=' is ok?
> Is it really confusing? SmallString doesn't have operator= for input. I
> could add that of course, but I don't really find this confusing. To me the
> worse bit is that there is a copy of this code in ParseObjC.cpp and in
> SemaExpr.cpp. :(
More information about the cfe-commits