[cfe-commits] r58817 - in /cfe/trunk: include/clang/AST/ include/clang/Basic/ include/clang/Parse/ lib/AST/ lib/Basic/ lib/Parse/ lib/Sema/ test/SemaCXX/ www/

[Doug Gregor]

On Mon, Nov 17, 2008 at 11:35 AM, Chris Lattner <clattner at apple.com> wrote:
> On Nov 17, 2008, at 8:17 AM, Doug Gregor wrote:
>> Yeah, I was thinking about this while writing up the documentation on
>> DeclarationName. DeclarationNameExtra::ExtraKind is going to end up
>> getting a bunch of new values, and this change will have to come
>> *after* we teach IdentifierResolver to work with DeclarationNames. I
>> think the end result will be better, though: IdentifierInfo can go
>> back to just dealing with identifiers and keywords, and
>> DeclarationName will encompass all kinds of names.
>
> Ok, makes sense.  I don't have any feeling on the relative ordering of these
> tasks, and there is no specific urgency to make the change.

Well, I need to do it to make conversion functions work properly, so
it'll be done soon anyway.

> If we have the Declarator object laying around, I think that would be a nice
> extension.  Declarator itself isn't very good at preserving source range
> information (unfortunately).  It even has a Declarator::getSourceRange()
> method that returns an empty range right now.
>
> I don't think it's a big priority, but this would be a very nice thing to
> add to Declarator and DeclaratorChunk::ParamInfo at some point.  If you're
> interested in this, please tackle it.  If not, don't worry about it :)

I added it to TODO.txt. It's not big enough to tackle now.

  - Doug