[cfe-commits] r59232 - /cfe/trunk/lib/Analysis/GRExprEngine.cpp

[Zhongxing Xu]

On Thu, Nov 13, 2008 at 10:57 PM, Ted Kremenek <kremenek at apple.com> wrote:

>
> On Nov 12, 2008, at 11:58 PM, Zhongxing Xu wrote:
>
> Author: zhongxingxu
> Date: Thu Nov 13 01:58:20 2008
> New Revision: 59232
>
> URL: http://llvm.org/viewvc/llvm-project?rev=59232&view=rev
> Log:
> Lift the pointer to alloca'ed region to the pointer to its first element.
> This is required by some operations, e.g., *p = 1; p[0] = 1;.
> Also set the AllocaRegion's type during the cast.
>
> +        // Set the AllocaRegion's type.
> +        const_cast<AllocaRegion*>(AR)->setType(T);
>
>
> Hi Zhongxing,
>
> I don't think this is the way to go.  MemRegions must be immutable.
>  Moreover, this reasoning should not go in GRExprEngine.
>

Hi Ted,

I rewrite the code with an AnonTypedRegion created to attach type
information to. Please review it.

>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081114/0a8fbced/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: anon.patch
Type: application/octet-stream
Size: 5019 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081114/0a8fbced/attachment.obj>