[cfe-commits] r58054 - /cfe/trunk/lib/AST/InheritViz.cpp

Ted Kremenek kremenek at apple.com
Thu Oct 23 17:11:49 PDT 2008


On Oct 23, 2008, at 5:07 PM, Douglas Gregor wrote:

> On Oct 23, 2008, at 4:55 PM, Ted Kremenek wrote:
>
>> Author: kremenek
>> Date: Thu Oct 23 18:55:40 2008
>> New Revision: 58054
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=58054&view=rev
>> Log:
>> Use llvm::errs() instead of cerr.
>>
>> Modified:
>>   cfe/trunk/lib/AST/InheritViz.cpp
>>
>> Modified: cfe/trunk/lib/AST/InheritViz.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/InheritViz.cpp?rev=58054&r1=58053&r2=58054&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- cfe/trunk/lib/AST/InheritViz.cpp (original)
>> +++ cfe/trunk/lib/AST/InheritViz.cpp Thu Oct 23 18:55:40 2008
>> @@ -137,30 +137,30 @@
>> /// class using GraphViz.
>> void QualType::viewInheritance(ASTContext& Context) {
>>  if (!(*this)->getAsRecordType()) {
>> -    cerr << "Type " << getAsString() << " is not a C++ class type. 
>> \n";
>> +    llvm::errs() << "Type " << getAsString() << " is not a C++  
>> class type.\n";
>>    return;
>>  }
>> #ifndef NDEBUG
>
> Since viewInheritance can now be called from the command line, we  
> should remove all of the #ifndef NDEBUG's from this file.
>
> 	- Doug

Go for it, although we should test that it actually works in Release  
mode before committing that change.





More information about the cfe-commits mailing list