[cfe-commits] r58028 - in /cfe/trunk: include/clang/Analysis/PathSensitive/GRState.h include/clang/Analysis/PathSensitive/Store.h lib/Analysis/BasicStore.cpp lib/Analysis/GRExprEngine.cpp

[Zhongxing Xu]

On Thu, Oct 23, 2008 at 12:07 PM, Ted Kremenek <kremenek at apple.com> wrote:

> Looks great Zhongxing.  Just one comment (inline).
>
> On Oct 22, 2008, at 8:10 PM, Zhongxing Xu wrote:
>
>  --- cfe/trunk/lib/Analysis/GRExprEngine.cpp (original)
>> +++ cfe/trunk/lib/Analysis/GRExprEngine.cpp Wed Oct 22 22:10:39 2008
>> @@ -1503,9 +1503,15 @@
>>        MakeNode(Dst, CastE, N, SetSVal(St, CastE, V));
>>        continue;
>>      }
>> -
>> +
>> +    // StoreManager casts array to different values.
>> +    if (ExTy->isArrayType()) {
>>
>
> Should we put an assertion here that the CastE->getType() is a pointer?
>

Added.


>
>
>
>> +      V = StateMgr.ArrayToPointer(V);
>> +      MakeNode(Dst, CastE, N, SetSVal(St, CastE, V));
>> +      continue;
>> +    }
>> +
>>    // All other cases.
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081023/4fbcd5d8/attachment.html>