[cfe-commits] [PATCH] getLValueElement

Ted Kremenek kremenek at apple.com
Wed Oct 22 18:28:53 PDT 2008


On Oct 22, 2008, at 6:26 PM, Zhongxing Xu wrote:

>
> This assertion will always be true.  Did you mean assert(false &&  
> "...")?
>
> No, I just don't want the program to crash when things happen, but  
> also put reminder there.
>
> Then it's not really an assertion.  Just use a comment.
>
> OK. I'll make it a comment. But I do see others doing this in Clang.

Those places are probably miswritten assertions.  When you spot them  
feel free to bring it to everyone's attention or submit a patch.

Thanks Zhongxing!



More information about the cfe-commits mailing list