[cfe-commits] r57719 - in /cfe/trunk: include/clang/Analysis/PathSensitive/GRCoreEngine.h lib/Analysis/GRCoreEngine.cpp

Ted Kremenek kremenek at apple.com
Fri Oct 17 13:49:24 PDT 2008


Author: kremenek
Date: Fri Oct 17 15:49:23 2008
New Revision: 57719

URL: http://llvm.org/viewvc/llvm-project?rev=57719&view=rev
Log:
Fixed an elusive caching bug in ExplodedGraph construction when a PostStmtKind was used instead of a PostStoreKind.

Modified:
    cfe/trunk/include/clang/Analysis/PathSensitive/GRCoreEngine.h
    cfe/trunk/lib/Analysis/GRCoreEngine.cpp

Modified: cfe/trunk/include/clang/Analysis/PathSensitive/GRCoreEngine.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/GRCoreEngine.h?rev=57719&r1=57718&r2=57719&view=diff

==============================================================================
--- cfe/trunk/include/clang/Analysis/PathSensitive/GRCoreEngine.h (original)
+++ cfe/trunk/include/clang/Analysis/PathSensitive/GRCoreEngine.h Fri Oct 17 15:49:23 2008
@@ -235,8 +235,12 @@
   }
   
   NodeTy* MakeNode(ExplodedNodeSet<StateTy>& Dst, Stmt* S,
-                   NodeTy* Pred, const StateTy* St,
-                   ProgramPoint::Kind K = ProgramPoint::PostStmtKind) {    
+                   NodeTy* Pred, const StateTy* St) {
+    return MakeNode(Dst, S, Pred, St, PointKind);
+  }
+  
+  NodeTy* MakeNode(ExplodedNodeSet<StateTy>& Dst, Stmt* S,
+                   NodeTy* Pred, const StateTy* St, ProgramPoint::Kind K) {    
     
     const StateTy* PredState = GetState(Pred);
         

Modified: cfe/trunk/lib/Analysis/GRCoreEngine.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/GRCoreEngine.cpp?rev=57719&r1=57718&r2=57719&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/GRCoreEngine.cpp (original)
+++ cfe/trunk/lib/Analysis/GRCoreEngine.cpp Fri Oct 17 15:49:23 2008
@@ -318,6 +318,9 @@
     case ProgramPoint::PostLoadKind:
       return PostLoad(S);
       
+    case ProgramPoint::PostStoreKind:
+      return PostStore(S);
+      
     case ProgramPoint::PostPurgeDeadSymbolsKind:
       return PostPurgeDeadSymbols(S);
   }





More information about the cfe-commits mailing list