[cfe-commits] r57563 - in /cfe/trunk: include/clang/AST/X86Builtins.def lib/CodeGen/CGBuiltin.cpp

[Mon Ping Wang]

Hi Dan,

Thanks. I'll also add this to x86-builtins.c

   --Mon Ping

On Oct 15, 2008, at 10:01 AM, Daniel Dunbar wrote:

>
> +BUILTIN(__builtin_ia32_vec_set_v2di, "V2LLV2LLLLi", "")
>
> This should be "V2LLiV2LLiLLi"?
>
> Also, could you add these to tests/Codegen/x86-builtins.c? It's  
> currently XFAIL so it doesn't do much but conceivably it would catch  
> errors like the above.
>
>  - Daniel
>
>
> +BUILTIN(__builtin_ia32_insertps128, "V4fV4fV4fi", "")
>
>  BUILTIN(__builtin_ia32_movqv4si, "V4iV4i", "")
>  BUILTIN(__builtin_ia32_loadlv4si, "V4iV2i*", "")
>
> Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=57563&r1=57562&r2=57563&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- cfe/trunk/lib/CodeGen/CGBuiltin.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGBuiltin.cpp Wed Oct 15 01:18:34 2008
> @@ -902,6 +902,10 @@
>   case X86::BI__builtin_ia32_vec_set_v4hi:
>   case X86::BI__builtin_ia32_vec_set_v8hi:
>     return Builder.CreateInsertElement(Ops[0], Ops[1], Ops[2],  
> "pinsrw");
> +  case X86::BI__builtin_ia32_vec_set_v4si:
> +    return Builder.CreateInsertElement(Ops[0], Ops[1], Ops[2],  
> "pinsrd");
> +  case X86::BI__builtin_ia32_vec_set_v2di:
> +    return Builder.CreateInsertElement(Ops[0], Ops[1], Ops[2],  
> "pinsrq");
>   case X86::BI__builtin_ia32_andps:
>   case X86::BI__builtin_ia32_andpd:
>   case X86::BI__builtin_ia32_andnps:
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081017/3d09e516/attachment.html>