[cfe-commits] Better const_cast support

Argiris Kirtzidis akyrtzi at gmail.com
Sun Sep 28 06:05:00 PDT 2008


Hi Sebastian,

> +  case tok::kw_const_cast:
> +    Op = CXXCastExpr::ConstCast;
> +    if (!CheckConstCast(OpLoc, Ex, DestType))
> +      return ExprResult(true);
> +    break;
>   

Could you please let it return a CXXCastExpr node even in case of an 
error ? :

+  case tok::kw_const_cast:
+    Op = CXXCastExpr::ConstCast;
+    CheckConstCast(OpLoc, Ex, DestType)
+    break;

In general, it is better if the AST is as complete as possible, even in 
case of semantic errors.


-Argiris



More information about the cfe-commits mailing list