[cfe-commits] r55417 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/DiagnosticKinds.def include/clang/Basic/LangOptions.h include/clang/Parse/DeclSpec.h lib/AST/ASTContext.cpp lib/AST/Type.cpp lib/AST/TypeSerialization.cpp lib/Parse/ParseDecl.cpp lib/Sema/SemaType.cpp test/Parser/block-pointer-decl.c

[Chris Lattner]

On Aug 27, 2008, at 3:16 PM, Argiris Kirtzidis wrote:

> Chris Lattner wrote:
>> On Aug 27, 2008, at 10:05 AM, Ted Kremenek wrote:
>>> On Aug 27, 2008, at 9:40 AM, Argiris Kirtzidis wrote:
>>>> Should there be a "-fapple-extensions" option ?
>>>
>>>
>>> Not certain.  It's enabled by default in Snow Leopard's gcc.   
>>> Clearly
>>> not all architectures need or want support for Blocks enabled by
>>> default.
>>
>> I was planning to treat it as "just another GCC extension", which  
>> interacts normally with -pedantic etc.  The feature doesn't change  
>> the meaning of any already-valid code, but if you think there  
>> should be a way to turn it off, we can certainly add a -fapple- 
>> extensions option (which would default to on on darwin).  There are  
>> a bunch of other apple-only features that this could control, like  
>> pascal strings etc.
>>
>> What do you think?
>
> It's better if extensions have a clear context and origin,  
> separating the Apple extensions from the GCC extensions seems like a  
> good idea to me.

Ok, in this case, blocks is guarded by its own langoptions flag, we  
can coarsen that if desired once it is feature complete.

-Chris