[cfe-commits] r55244 - /cfe/trunk/lib/CodeGen/CGExprAgg.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Sat Aug 23 13:44:10 2008
New Revision: 55244

URL: http://llvm.org/viewvc/llvm-project?rev=55244&view=rev
Log:
Drop a dead call to isConstantExpr()

Modified:
    cfe/trunk/lib/CodeGen/CGExprAgg.cpp

Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprAgg.cpp?rev=55244&r1=55243&r2=55244&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CGExprAgg.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGExprAgg.cpp Sat Aug 23 13:44:10 2008
@@ -371,14 +371,12 @@
 }
 
 void AggExprEmitter::VisitInitListExpr(InitListExpr *E) {
-  if (E->isConstantExpr(CGF.getContext(), 0)) {
-    // FIXME: call into const expr emitter so that we can emit
-    // a memcpy instead of storing the individual members.
-    // This is purely for perf; both codepaths lead to equivalent
-    // (although not necessarily identical) code.
-    // It's worth noting that LLVM keeps on getting smarter, though,
-    // so it might not be worth bothering.
-  }
+  // FIXME: For constant expressions, call into const expr emitter so
+  // that we can emit a memcpy instead of storing the individual
+  // members.  This is purely for perf; both codepaths lead to
+  // equivalent (although not necessarily identical) code.  It's worth
+  // noting that LLVM keeps on getting smarter, though, so it might
+  // not be worth bothering.
   
   // Handle initialization of an array.
   if (E->getType()->isArrayType()) {