[cfe-commits] r54598 - /cfe/trunk/lib/AST/Expr.cpp

[Daniel Dunbar]

Ok, this is better than what was before, but we still need to handle this case
if we want gems like
--
enum x { v = (char*) 0 - (char*) 0 };
--
to behave as they do in GCC.


 - Daniel


----- Original Message ----
From: Eli Friedman <eli.friedman at gmail.com>
To: cfe-commits at cs.uiuc.edu
Sent: Saturday, August 9, 2008 3:24:21 PM
Subject: [cfe-commits] r54598 - /cfe/trunk/lib/AST/Expr.cpp

Author: efriedma
Date: Sat Aug  9 17:24:21 2008
New Revision: 54598

URL: http://llvm.org/viewvc/llvm-project?rev=54598&view=rev
Log:
Remove the ICE pointer cast hack; the issue this was working around is 
now fixed in an alternate way.


Modified:
    cfe/trunk/lib/AST/Expr.cpp

Modified: cfe/trunk/lib/AST/Expr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Expr.cpp?rev=54598&r1=54597&r2=54598&view=diff

==============================================================================
--- cfe/trunk/lib/AST/Expr.cpp (original)
+++ cfe/trunk/lib/AST/Expr.cpp Sat Aug  9 17:24:21 2008
@@ -955,11 +955,6 @@
     if (!SubExpr->getType()->isArithmeticType() ||
         !getType()->isIntegerType()) {
       if (Loc) *Loc = SubExpr->getLocStart();
-      // GCC accepts pointers as an extension.
-      // FIXME: check getLangOptions().NoExtensions. At the moment, it doesn't
-      // appear possible to get langOptions() from the Expr.
-      if (SubExpr->getType()->isPointerType()) // && !NoExtensions
-        return true;
       return false;
     }



_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits