[cfe-commits] r54034 - /cfe/trunk/lib/Analysis/CheckObjCDealloc.cpp

Ted Kremenek kremenek at apple.com
Fri Jul 25 11:17:35 PDT 2008


Author: kremenek
Date: Fri Jul 25 13:17:35 2008
New Revision: 54034

URL: http://llvm.org/viewvc/llvm-project?rev=54034&view=rev
Log:
Remove call to isSEL and isSEL itself since the call is dead (isObjCObjectPointerType() will never return true for selectors).

Modified:
    cfe/trunk/lib/Analysis/CheckObjCDealloc.cpp

Modified: cfe/trunk/lib/Analysis/CheckObjCDealloc.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/CheckObjCDealloc.cpp?rev=54034&r1=54033&r2=54034&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/CheckObjCDealloc.cpp (original)
+++ cfe/trunk/lib/Analysis/CheckObjCDealloc.cpp Fri Jul 25 13:17:35 2008
@@ -42,13 +42,6 @@
   return false;
 }
 
-static bool isSEL(QualType T, IdentifierInfo* SelII) {
-  if (const TypedefType* Ty = T->getAsTypedefType())
-    return Ty->getDecl()->getIdentifier() == SelII;
-  
-  return false;
-}
-
 void clang::CheckObjCDealloc(ObjCImplementationDecl* D,
                              const LangOptions& LOpts, BugReporter& BR) {
 
@@ -63,7 +56,6 @@
   //        http://llvm.org/bugs/show_bug.cgi?id=2517
   
   bool containsPointerIvar = false;
-  IdentifierInfo* SelII = &Ctx.Idents.get("SEL");
   
   for (ObjCInterfaceDecl::ivar_iterator I=ID->ivar_begin(), E=ID->ivar_end();
        I!=E; ++I) {
@@ -72,8 +64,7 @@
     QualType T = ID->getType();
     
     if (!Ctx.isObjCObjectPointerType(T) ||
-        ID->getAttr<IBOutletAttr>() || // Skip IBOutlets.
-        isSEL(T, SelII)) // Skip SEL ivars.
+        ID->getAttr<IBOutletAttr>()) // Skip IBOutlets.
       continue;
     
     containsPointerIvar = true;





More information about the cfe-commits mailing list