[cfe-commits] r51502 - /cfe/trunk/lib/Sema/SemaDecl.cpp

[Ted Kremenek]

Author: kremenek
Date: Fri May 23 16:28:18 2008
New Revision: 51502

URL: http://llvm.org/viewvc/llvm-project?rev=51502&view=rev
Log:
Revert r51498: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=51498&r1=51497&r2=51498&view=diff

Turns out that there are multiple places where a redefinition diagnostic can be emitted.  A cleaner solution (without touching Sema) is to have
the Driver turn off these diagnostics.  (will submit this patch soon)

Modified:
    cfe/trunk/lib/Sema/SemaDecl.cpp

Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=51502&r1=51501&r2=51502&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDecl.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDecl.cpp Fri May 23 16:28:18 2008
@@ -258,10 +258,8 @@
   // TODO: CHECK FOR CONFLICTS, multiple decls with same name in one scope.
   // TODO: This is totally simplistic.  It should handle merging functions
   // together etc, merging extern int X; int X; ...
-  // FIXME: temporarily removing this diagnostic (5/23/08). Will put back
-  // next week (which the .i file FIXME above is nailed).
-  //Diag(New->getLocation(), diag::err_redefinition, New->getName());
-  //Diag(Old->getLocation(), diag::err_previous_definition);
+  Diag(New->getLocation(), diag::err_redefinition, New->getName());
+  Diag(Old->getLocation(), diag::err_previous_definition);
   return New;
 }