[cfe-commits] r51364 - in /cfe/trunk: Driver/SerializationTest.cpp include/clang/AST/TranslationUnit.h lib/AST/TranslationUnit.cpp

[Ted Kremenek]

On May 20, 2008, at 10:33 PM, Eli Friedman wrote:

> Author: efriedma
> Date: Wed May 21 00:33:10 2008
> New Revision: 51364
>
> URL: http://llvm.org/viewvc/llvm-project?rev=51364&view=rev
> Log:
> Fix the destruction "properly" in the sense that we actually destroy  
> the
> ASTs.  This is a hack, but I haven't considered how we really
> want to do this.

I agree that this is a hack.  TranslationUnit currently has dual modes  
where it can own certain objects and delete them in its dstor and not  
own them and not delete them.  I think this helps create bugs like  
these.  We definitely need a better design.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20080521/25fb374f/attachment.html>