[cfe-commits] r51188 - /cfe/trunk/lib/AST/Expr.cpp

[Eli Friedman]

On Fri, May 16, 2008 at 10:59 AM, Nate Begeman <nbegeman at apple.com> wrote:
> Hi Eli,
>
> I'm not totally sure that isBuiltinConstantExpr means what I think it means.
>  Would it be reasonable to add __builin_inf / nan / constant_p to this list,
> since they always return constants?

Well, isBuiltinConstantExpr currently only has one caller,
Expr::isConstantExpr, so we can define it in any way that makes sense.
  I think that adding __builin_inf / nan / constant_p to the list
would be reasonable.

(Although, how exactly can we evaluate __builtin_constant_p in clang?
Use isConstantExpr?)

-Eli