[cfe-commits] r51164 - /cfe/trunk/lib/AST/Expr.cpp

Ted Kremenek kremenek at apple.com
Thu May 15 14:49:04 PDT 2008


Author: kremenek
Date: Thu May 15 16:49:04 2008
New Revision: 51164

URL: http://llvm.org/viewvc/llvm-project?rev=51164&view=rev
Log:
Removed bogus "return true" in Expr::isConstantExpr that returned true for all
expressions. This appears to be a regression introduced in r51113 that caused
many test cases to fail (there is still a test case in the Analysis directory
that is failing):

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080512/005706.html

Modified:
    cfe/trunk/lib/AST/Expr.cpp

Modified: cfe/trunk/lib/AST/Expr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Expr.cpp?rev=51164&r1=51163&r2=51164&view=diff

==============================================================================
--- cfe/trunk/lib/AST/Expr.cpp (original)
+++ cfe/trunk/lib/AST/Expr.cpp Thu May 15 16:49:04 2008
@@ -500,7 +500,6 @@
 
 
 bool Expr::isConstantExpr(ASTContext &Ctx, SourceLocation *Loc) const {
-  return true;
   switch (getStmtClass()) {
   default:
     if (Loc) *Loc = getLocStart();





More information about the cfe-commits mailing list