[cfe-commits] r49817 - in /cfe/trunk: Driver/ASTConsumers.cpp include/clang/AST/DeclObjC.h lib/AST/DeclObjC.cpp lib/Sema/SemaDeclObjC.cpp

[Chris Lattner]

On Apr 17, 2008, at 9:37 AM, Fariborz Jahanian wrote:

>>> if (pNum != 0)
>>>   if (ObjCInterfaceDecl *IDecl =  
>>> dyn_cast<ObjCInterfaceDecl>(ClassDecl))
>>>     IDecl->addProperties((ObjCPropertyDecl**)allProperties, pNum);
>>> +    else
>>> +      if (ObjCCategoryDecl *CDecl =  
>>> dyn_cast<ObjCCategoryDecl>(ClassDecl))
>>> +        CDecl->addProperties((ObjCPropertyDecl**)allProperties,  
>>> pNum);
>>>
>>> for (unsigned i = 0; i < allNum; i++ ) {
>>>   ObjCMethodDecl *Method =
>>
>> What if ClassDecl is neither an ObjCInterfaceDecl or a  
>> ObjCCategoryDecl?  Should there be an assert or error here?
>
> I still need to do more in this area. Protocols are OK,  
> implementations are not. Much more sementaics checking need be done.
>>
>

If there is more to be done, please insert a FIXME with a brief  
description of what is missing.  That way, people reading the code  
know the current limitations.  Thanks!

-Chris