[cfe-commits] r49699 - in /cfe/trunk: Driver/ASTConsumers.cpp include/clang/AST/DeclObjC.h include/clang/Parse/Action.h include/clang/Parse/Parser.h lib/AST/DeclObjC.cpp lib/Parse/ParseObjc.cpp lib/Sema/Sema.h lib/Sema/SemaDeclObjC.cpp
fjahanian at apple.com
Tue Apr 15 16:59:08 PDT 2008
On Apr 15, 2008, at 4:47 PM, Chris Lattner wrote:
> On Apr 15, 2008, at 4:48 PM, Fariborz Jahanian wrote:
>> On Apr 15, 2008, at 4:34 PM, Chris Lattner wrote:
>>> On Apr 14, 2008, at 4:36 PM, Fariborz Jahanian wrote:
>>>> Author: fjahanian
>>>> Date: Mon Apr 14 18:36:35 2008
>>>> New Revision: 49699
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=49699&view=rev
>>>> New AST representation for each objc2's property declaration.
>>> Nice, thanks Fariborz!
>>> I think that the propertydecl enum in DeclBase.h needs to be moved
>>> to reflect its new place in the class hierarchy.
>> I am not sure what you mean. ObjCPropertyDecl is derived from
>> NamedDecl and it seems to be in the correct position.
> Oh, right!
>>> Also, given the new approach, should ObjCPropertyDecl inherit from
>>> FieldDecl, what do you think?
>> Think of a property declaration as macro for declaring setters and
>> getters. It really has nothing to do with fields.
> Ok, I guess what I'm getting at is that it would be nice for
> interfaces to have a single list of "stuff in them", which would
> include ivars and properties. Maybe there should be a class below
> FieldDecl that PropertyDecl and FieldDecl both inherit from?
I am not sure what will be accomplished by this, except for saving a
field in ObjCInterface AST node, at the expense of compile-time
Conceptually, ivars and properties are not related and IMO, do not
belong in the same list.
> I admit I'm out of my league here, Steve what do you think?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits