[cfe-commits] r48453 - in /cfe/trunk/test: Makefile.parallel TestRunner.sh

[Gabor Greif]

Author: ggreif
Date: Mon Mar 17 07:35:00 2008
New Revision: 48453

URL: http://llvm.org/viewvc/llvm-project?rev=48453&view=rev
Log:
Second round of review feedback.

* print out message when tests start
* testrunner sets status now
* on failed test run print out test name

I tested these changes with the non-parallel makefile
and it did not break.

Modified:
    cfe/trunk/test/Makefile.parallel
    cfe/trunk/test/TestRunner.sh

Modified: cfe/trunk/test/Makefile.parallel
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Makefile.parallel?rev=48453&r1=48452&r2=48453&view=diff

==============================================================================
--- cfe/trunk/test/Makefile.parallel (original)
+++ cfe/trunk/test/Makefile.parallel Mon Mar 17 07:35:00 2008
@@ -14,7 +14,7 @@
 Makefile.tests:
 	@ echo '%.testresults: %' > $@
 	@ echo "^@ printf '.'" | tr "^" "\t" >> $@
-	@ echo "^@ PATH=$$PATH:$(ToolDir):$(LLVM_SRC_ROOT)/test/Scripts ./TestRunner.sh &< > &@ || echo $$^" | tr "^&" '\t$$' >> $@
+	@ echo "^@ PATH=$$PATH:$(ToolDir):$(LLVM_SRC_ROOT)/test/Scripts ./TestRunner.sh &< > &@ || (echo; echo '----' &! 'failed ----')" | tr '^!&' '\t^$$' >> $@
 	@ echo >> $@
 	@ echo "TESTS =" \\ >> $@
 	@ find $(TESTDIRS) \
@@ -33,6 +33,7 @@
 	@ echo ".PHONY: all report clean" >> $@
 
 all:: Makefile.tests
+	@ echo '--- Running clang tests ---'
 	@ $(MAKE) -f $< clean
 	@ $(MAKE) -f $< all report
 	@ $(MAKE) -f $< clean

Modified: cfe/trunk/test/TestRunner.sh
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/TestRunner.sh?rev=48453&r1=48452&r2=48453&view=diff

==============================================================================
--- cfe/trunk/test/TestRunner.sh (original)
+++ cfe/trunk/test/TestRunner.sh Mon Mar 17 07:35:00 2008
@@ -52,5 +52,6 @@
   cat $OUTPUT
   rm $OUTPUT
   echo "******************** TEST '$TESTNAME' FAILED! ********************"
+  exit 1
 )