[cfe-commits] only calculate target information once

Chris Lattner clattner at apple.com
Thu Mar 13 23:12:54 PDT 2008


On Mar 13, 2008, at 3:08 PM, Sam Bishop wrote:

> Hi, all.
>
> The attached patch moves the target-calculation code out of the file
> processing loop in main().  I had thought there might be some other
> things that could be lifted out of the loop, but it looks like
> everything else changes if the source language changes.
>
> I also added a "delete"; valgrind complains otherwise.

Very nice:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080310/004688.html

I forgot to mention, in the previous patch I turned "if (x) delete x;"  
to "delete x".  delete handles null pointers correctly.

-Chris



More information about the cfe-commits mailing list