[cfe-commits] r43282 - in /cfe/trunk/CodeGen: CodeGenTypes.cpp CodeGenTypes.h

[Devang Patel]

Author: dpatel
Date: Tue Oct 23 19:32:16 2007
New Revision: 43282

URL: http://llvm.org/viewvc/llvm-project?rev=43282&view=rev
Log:
Add notes.

Modified:
    cfe/trunk/CodeGen/CodeGenTypes.cpp
    cfe/trunk/CodeGen/CodeGenTypes.h

Modified: cfe/trunk/CodeGen/CodeGenTypes.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/CodeGen/CodeGenTypes.cpp?rev=43282&r1=43281&r2=43282&view=diff

==============================================================================
--- cfe/trunk/CodeGen/CodeGenTypes.cpp (original)
+++ cfe/trunk/CodeGen/CodeGenTypes.cpp Tue Oct 23 19:32:16 2007
@@ -176,6 +176,8 @@
         return OpaqueI->second;
 
       // Create new OpaqueType now for later use.
+      // FIXME: This creates a lot of opaque types, most of which are not needed.  
+      // Reevaluate this when performance analyis finds tons of opaque types.
       llvm::OpaqueType *OpaqueTy =  llvm::OpaqueType::get();
       RecordTypesToResolve[RD] = OpaqueTy;
 

Modified: cfe/trunk/CodeGen/CodeGenTypes.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/CodeGen/CodeGenTypes.h?rev=43282&r1=43281&r2=43282&view=diff

==============================================================================
--- cfe/trunk/CodeGen/CodeGenTypes.h (original)
+++ cfe/trunk/CodeGen/CodeGenTypes.h Tue Oct 23 19:32:16 2007
@@ -94,6 +94,8 @@
 
   /// RecordLayouts - This maps llvm struct type with corresponding 
   /// record layout info. 
+  /// FIXME : If RecordLayoutInfo is less than 16 bytes then use 
+  /// inline it in the map.
   llvm::DenseMap<const llvm::Type*, RecordLayoutInfo *> RecordLayouts;
 
   /// FieldInfo - This maps struct field with corresponding llvm struct type