[cfe-commits] r43236 - in /cfe/trunk/CodeGen: CodeGenFunction.cpp CodeGenFunction.h CodeGenTypes.cpp CodeGenTypes.h

[Chris Lattner]

On Oct 23, 2007, at 5:17 PM, Devang Patel wrote:

>
> On Oct 23, 2007, at 5:11 PM, Chris Lattner wrote:
>
>>
>> On Oct 23, 2007, at 5:09 PM, Devang Patel wrote:
>>
>>>>> @@ -39,14 +89,33 @@
>>>>>  llvm::Module& TheModule;
>>>>>
>>>>>  llvm::DenseMap<const TagDecl*, llvm::Type*> TagDeclTypes;
>>>>> +
>>>>> +  /// RecordLayouts - This maps llvm struct type with  
>>>>> corresponding
>>>>> +  /// record layout info.
>>>>> +  llvm::DenseMap<const llvm::Type*, RecordLayoutInfo *>  
>>>>> RecordLayouts;
>>>>
>>>> RLI is currently only a single pointer.  Do you expect it to grow?
>>>
>>> Yes. It will have special info for fields that requires masking  
>>> during load and store.
>>
>> Ok, do you think it will end up being 8 bytes?  If it is <= 12  
>> bytes, it's a clear win to put it inline into DenseMap.  If it is  
>> 16 bytes it is a likely win, but would have to be tested.
>
> I am not sure. It will depend upon number of fields that are not  
> directly mapped into llvm struct field.
> I'll add note now.

ok!

-chris