[cfe-commits] r43074 - in /cfe/trunk: CodeGen/CGExprScalar.cpp CodeGen/CodeGenFunction.h CodeGen/CodeGenModule.cpp Driver/SerializationTest.cpp include/clang/Basic/IdentifierTable.h win32/clangDriver/clangDriver.vcproj

[Hartmut Kaiser]

> Chris, 

Sorry, I meant Ted!

Regards Hartmut

> > Thanks Hartmut.  It's interesting that visual c++ has problems 
> > compiling it.  Just so that is easier to spot patches like this, in 
> > the future could you separate (when
> > possible) patches into smaller patches?  For example, the 
> patch to the 
> > serialization code has nothing to do with your modifications to the 
> > CodeGen code, so making two separate patches here would 
> have made it 
> > easier to see what changed.
> > Basically I see two orthogonal concepts here; making 
> patches include 
> > only related changes makes them easier to read.
> 
> Understood. 
> 
> > Another point I should mention is that while your patch is 
> correct, it 
> > goes against the design I was going after (which 
> illustrates that my 
> > design is not portable).  Template specialization of inner classes 
> > without having to specialize the outer class is a useful 
> feature when 
> > you don't want to redefine (i.e. specialize) the entire outer class.
> 
> Agreed.
> 
> > Since I
> > only had one example in my code of doing specialization of an inner 
> > class, this design point didn't show up in my code.
> > Clearly visual c++ doesn't support this, so I will have to find 
> > another way.
> 
> Agreed again.
> Regards Hartmut
> 
>