[cfe-commits] r41613 - in /cfe/trunk: AST/Expr.cpp Sema/Sema.h Sema/SemaExpr.cpp include/clang/AST/Expr.h include/clang/AST/StmtVisitor.h include/clang/Basic/DiagnosticKinds.def

Neil Booth neil at daikokuya.co.uk
Fri Aug 31 10:26:09 PDT 2007

Chris Lattner wrote:-

> >But your example has convinced me that restricting this offsetof to
> >just an identifier is probably a good idea - accepting generic
> >expressions can get out of control.
> Ok, at this point, we now support the simple case (which is arguably  
> what the standard intends), and support what GCC does, diagnosing it  
> as an extended form of offsetof.  I think this is a good tradeoff: it  
> gives us compatibility with the standard and with GCC, and has low  
> complexity.  What a mess!

I tend to agree this is the best choice for LLVM.


More information about the cfe-commits mailing list