[cfe-commits] r39591 - /cfe/cfe/trunk/Sema/SemaExpr.cpp

[clattner at cs.uiuc.edu]

Author: clattner
Date: Wed Jul 11 11:46:01 2007
New Revision: 39591

URL: http://llvm.org/viewvc/llvm-project?rev=39591&view=rev
Log:
add some fixme's for incorrect sema

Modified:
    cfe/cfe/trunk/Sema/SemaExpr.cpp

Modified: cfe/cfe/trunk/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/cfe/trunk/Sema/SemaExpr.cpp?rev=39591&r1=39590&r2=39591&view=diff

==============================================================================
--- cfe/cfe/trunk/Sema/SemaExpr.cpp (original)
+++ cfe/cfe/trunk/Sema/SemaExpr.cpp Wed Jul 11 11:46:01 2007
@@ -453,6 +453,7 @@
               SourceLocation RParenLoc, ExprTy *Op) {
   // If error parsing type, ignore.
   assert((Ty != 0) && "ParseCastExpr(): missing type");
+  // FIXME: Sema for cast is completely missing.
   return new CastExpr(QualType::getFromOpaquePtr(Ty), (Expr*)Op, LParenLoc);
 }
 
@@ -778,6 +779,8 @@
 inline QualType Sema::CheckShiftOperands( // C99 6.5.7
   Expr *lex, Expr *rex, SourceLocation loc)
 {
+  // FIXME: Shifts don't perform usual arithmetic conversions.  This is wrong
+  // for int << longlong -> the result type should be int, not long long.
   QualType resType = UsualArithmeticConversions(lex->getType(), rex->getType());
   
   if (resType->isIntegerType())