[cfe-commits] r39386 - /cfe/cfe/trunk/Lex/LiteralSupport.cpp

clattner at cs.uiuc.edu clattner at cs.uiuc.edu
Wed Jul 11 09:43:50 PDT 2007


Author: clattner
Date: Wed Jul 11 11:43:50 2007
New Revision: 39386

URL: http://llvm.org/viewvc/llvm-project?rev=39386&view=rev
Log:
Ah, this is already correctly rejected!

Modified:
    cfe/cfe/trunk/Lex/LiteralSupport.cpp

Modified: cfe/cfe/trunk/Lex/LiteralSupport.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/cfe/trunk/Lex/LiteralSupport.cpp?rev=39386&r1=39385&r2=39386&view=diff

==============================================================================
--- cfe/cfe/trunk/Lex/LiteralSupport.cpp (original)
+++ cfe/cfe/trunk/Lex/LiteralSupport.cpp Wed Jul 11 11:43:50 2007
@@ -281,12 +281,7 @@
     unsigned C = HexLetterToVal(*s++);
     
     // If this letter is out of bound for this radix, reject it.
-    if (C >= radix) {
-      // FIXME: This is an error, not a warning.  This should be caught by
-      // NumericLiteralParser ctor.
-      C = C % radix;
-      OverflowOccurred = true;
-    }
+    assert(C < radix && "NumericLiteralParser ctor should have rejected this");
     
     CharVal = C;
     





More information about the cfe-commits mailing list