<div dir="ltr">Hello Tyker,<div>Sorry, but it turned out that I made a mistake and your change is not responsible,</div><div>so need to rollback!</div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><font color="#999999"><br></font></div><font color="#999999">--Tobi</font><br></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 25, 2020 at 2:27 PM Tobias Bosch <<a href="mailto:tbosch@google.com">tbosch@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Added the correct email-address...</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 25, 2020 at 2:15 PM Tobias Bosch <<a href="mailto:tbosch@google.com" target="_blank">tbosch@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hello Tyker,<div>we're seeing your commit c95ffadb2474a4d8c4f598d94d35a9f31d9606cb having caused problems with miscompiles in a testcase. Would you mind reverting this temporarily and I'll try to get you a testcase?<br><div><br></div><div>Thanks!</div><div><div><div dir="ltr"><div dir="ltr"><div><font color="#999999"><br></font></div><font color="#999999">--Tobi</font><br></div></div></div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 25, 2020 at 4:00 AM Ralender via All-commits <<a href="mailto:all-commits@lists.llvm.org" target="_blank">all-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Branch: refs/heads/master<br>
Home: <a href="https://github.com/llvm/llvm-project" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project</a><br>
Commit: 8938a6c9ede29a2d738357c44d66a017d74fcc7e<br>
<a href="https://github.com/llvm/llvm-project/commit/8938a6c9ede29a2d738357c44d66a017d74fcc7e" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8938a6c9ede29a2d738357c44d66a017d74fcc7e</a><br>
Author: Tyker <<a href="mailto:tyker1@outlook.com" target="_blank">tyker1@outlook.com</a>><br>
Date: 2020-06-25 (Thu, 25 Jun 2020)<br>
<br>
Changed paths:<br>
M clang/test/CodeGen/align_value.cpp<br>
M clang/test/CodeGen/alloc-align-attr.c<br>
M clang/test/CodeGen/builtin-align.c<br>
M clang/test/CodeGen/builtin-assume-aligned.c<br>
M llvm/test/Transforms/AlignmentFromAssumptions/simple32.ll<br>
M llvm/test/Transforms/Inline/align.ll<br>
<br>
Log Message:<br>
-----------<br>
[NFC] update test to make diff of the following commit clear<br>
<br>
<br>
Commit: c95ffadb2474a4d8c4f598d94d35a9f31d9606cb<br>
<a href="https://github.com/llvm/llvm-project/commit/c95ffadb2474a4d8c4f598d94d35a9f31d9606cb" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c95ffadb2474a4d8c4f598d94d35a9f31d9606cb</a><br>
Author: Tyker <<a href="mailto:tyker1@outlook.com" target="_blank">tyker1@outlook.com</a>><br>
Date: 2020-06-25 (Thu, 25 Jun 2020)<br>
<br>
Changed paths:<br>
M clang/lib/CodeGen/CodeGenFunction.cpp<br>
M clang/test/CodeGen/align_value.cpp<br>
M clang/test/CodeGen/alloc-align-attr.c<br>
M clang/test/CodeGen/assume-aligned-and-alloc-align-attributes.c<br>
M clang/test/CodeGen/builtin-align-array.c<br>
M clang/test/CodeGen/builtin-align.c<br>
M clang/test/CodeGen/builtin-assume-aligned.c<br>
M clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-lvalue.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-paramvar.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-attribute-assume_aligned-on-function-two-params.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-attribute-assume_aligned-on-function.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-three-params-variable.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-three-params.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-two-params.cpp<br>
M clang/test/CodeGen/catch-alignment-assumption-openmp.cpp<br>
M clang/test/CodeGen/non-power-of-2-alignment-assumptions.c<br>
M clang/test/OpenMP/simd_codegen.cpp<br>
M clang/test/OpenMP/simd_metadata.c<br>
M clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp<br>
M llvm/include/llvm/IR/IRBuilder.h<br>
M llvm/lib/Analysis/AssumeBundleQueries.cpp<br>
M llvm/lib/IR/IRBuilder.cpp<br>
M llvm/lib/IR/Verifier.cpp<br>
M llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp<br>
M llvm/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp<br>
M llvm/test/Transforms/AlignmentFromAssumptions/simple.ll<br>
M llvm/test/Transforms/AlignmentFromAssumptions/simple32.ll<br>
M llvm/test/Transforms/Inline/align.ll<br>
M llvm/test/Transforms/InstCombine/assume.ll<br>
M llvm/test/Transforms/PhaseOrdering/inlining-alignment-assumptions.ll<br>
M llvm/test/Verifier/assume-bundles.ll<br>
M llvm/unittests/Analysis/AssumeBundleQueriesTest.cpp<br>
<br>
Log Message:<br>
-----------<br>
[AssumeBundles] Use operand bundles to encode alignment assumptions<br>
<br>
Summary:<br>
NOTE: There is a mailing list discussion on this: <a href="http://lists.llvm.org/pipermail/llvm-dev/2019-December/137632.html" rel="noreferrer" target="_blank">http://lists.llvm.org/pipermail/llvm-dev/2019-December/137632.html</a><br>
<br>
Complemantary to the assumption outliner prototype in D71692, this patch<br>
shows how we could simplify the code emitted for an alignemnt<br>
assumption. The generated code is smaller, less fragile, and it makes it<br>
easier to recognize the additional use as a "assumption use".<br>
<br>
As mentioned in D71692 and on the mailing list, we could adopt this<br>
scheme, and similar schemes for other patterns, without adopting the<br>
assumption outlining.<br>
<br>
Reviewers: hfinkel, xbolva00, lebedev.ri, nikic, rjmccall, spatel, jdoerfert, sstefan1<br>
<br>
Reviewed By: jdoerfert<br>
<br>
Subscribers: yamauchi, kuter, fhahn, merge_guards_bot, hiraditya, bollu, rkruppe, cfe-commits, llvm-commits<br>
<br>
Tags: #clang, #llvm<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D71739" rel="noreferrer" target="_blank">https://reviews.llvm.org/D71739</a><br>
<br>
<br>
Compare: <a href="https://github.com/llvm/llvm-project/compare/043b60839955...c95ffadb2474" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/compare/043b60839955...c95ffadb2474</a><br>
_______________________________________________<br>
All-commits mailing list<br>
<a href="mailto:All-commits@lists.llvm.org" target="_blank">All-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/all-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/all-commits</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>