[all-commits] [llvm/llvm-project] 01ea93: [CostModel] remove cost-kind predicate for memcpy ...

RotateRight via All-commits all-commits at lists.llvm.org
Wed Oct 21 06:10:58 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 01ea93d85d6e2240d70daf52e84772aba310bc19
      https://github.com/llvm/llvm-project/commit/01ea93d85d6e2240d70daf52e84772aba310bc19
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-10-21 (Wed, 21 Oct 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/BasicTTIImpl.h
    M llvm/test/Analysis/CostModel/X86/intrinsic-cost-kinds.ll

  Log Message:
  -----------
  [CostModel] remove cost-kind predicate for memcpy cost

The default implementation base returns TCC_Expensive (currently
set to '4'), so that explains the test diff. This probably does
not make sense for most callers, but at least now the costs will
be consistently wrong instead of mysteriously wrong.

The ARM target has an override that tries to model codegen expansion,
and that should likely be adapted for general usage.

This probably does not affect anything because the vectorizers are
the primary users of the throughput cost, but memcpy is not listed
as a trivially vectorizable intrinsic.




More information about the All-commits mailing list