[all-commits] [llvm/llvm-project] 81c0d3: [LIT] error if directly named test won't be run in...

bd1976bris via All-commits all-commits at lists.llvm.org
Wed Oct 21 05:23:48 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 81c0d36a1836c9be7c34a6d8198310ad7ea9bb53
      https://github.com/llvm/llvm-project/commit/81c0d36a1836c9be7c34a6d8198310ad7ea9bb53
  Author: Ben Dunbobbin <Ben.Dunbobbin at sony.com>
  Date:   2020-10-21 (Wed, 21 Oct 2020)

  Changed paths:
    M llvm/utils/lit/lit/LitTestCase.py
    M llvm/utils/lit/lit/cl_arguments.py
    M llvm/utils/lit/lit/discovery.py
    M llvm/utils/lit/lit/main.py
    A llvm/utils/lit/tests/Inputs/discovery/test.not-txt
    M llvm/utils/lit/tests/discovery.py
    M llvm/utils/lit/tests/unit/TestRunner.py

  Log Message:
  -----------
  [LIT] error if directly named test won't be run indirectly

Currently, a LIT test named directly (on the command line) will
be run even if the name of the test file does not meet the rules
to be considered a test in the LIT test configuration files for
its test suite. For example, if the test does not have a
recognised file extension.

This makes it relatively easy to write a LIT test that won't
actually be run. I did in: https://reviews.llvm.org/D82567

This patch adds an error to avoid users doing that. There is a
small performance overhead for this check. A command line option
has been added so that users can opt into the old behaviour.

Differential Revision: https://reviews.llvm.org/D83069




More information about the All-commits mailing list