[all-commits] [llvm/llvm-project] d99b2a: [clangd][remote] Add Windows paths support

Aleksandr Platonov via All-commits all-commits at lists.llvm.org
Tue Oct 20 03:05:40 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d99b2a976a37f5a63117086d464df40c124f5777
      https://github.com/llvm/llvm-project/commit/d99b2a976a37f5a63117086d464df40c124f5777
  Author: Aleksandr Platonov <platonov.aleksandr at huawei.com>
  Date:   2020-10-20 (Tue, 20 Oct 2020)

  Changed paths:
    M clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp
    M clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp

  Log Message:
  -----------
  [clangd][remote] Add Windows paths support

Without this patch 6 marshalling tests fail on Windows.
This patch contains the following changes:
- Allow paths with Windows slashes (convert to the POSIX style instead of assertion)
- Add support for URI with Windows path.
- Change the value of the second parameter of several `llvm::sys::path::convert_to_slash()` calls: we should use `windows` instead of `posix` to ensure UNIX slashes in the path.
- Port `RemoteMarshallingTest::IncludeHeaderURI` test to Windows.

Reviewed By: kbobyrev

Differential Revision: https://reviews.llvm.org/D89529




More information about the All-commits mailing list