[all-commits] [llvm/llvm-project] 6a5f95: [llvm-readobj/elf] - Change the behavior of handin...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Mon Oct 19 05:08:47 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6a5f9503640ff38f537e19ca0be3440b13de3120
      https://github.com/llvm/llvm-project/commit/6a5f9503640ff38f537e19ca0be3440b13de3120
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-10-19 (Mon, 19 Oct 2020)

  Changed paths:
    M llvm/test/tools/llvm-readobj/ELF/dynamic-malformed.test
    M llvm/test/tools/llvm-readobj/ELF/dynamic-tags.test
    M llvm/test/tools/llvm-readobj/ELF/hash-table.test
    M llvm/test/tools/llvm-readobj/ELF/needed-libs.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readobj/elf] - Change the behavior of handing DT_SONAME.

The current situation/behavior is:
1) llvm-readelf doesn't need a string that is specified by `DT_SONAME`.
2) llvm-readobj/elf always tries to read it, even when there is no `DT_SONAME` tag.
3) Because of that both tools reports a warning for many our test cases.

This patch delays getting a SOName string and changes the behavior (llvm-readobj) to
only report a warning when there is a `DT_SONAME` and a string cab't be read.
Warning is not reported for llvm-readelf, as it never tries to dump it.

Differential revision: https://reviews.llvm.org/D89384




More information about the All-commits mailing list