[all-commits] [llvm/llvm-project] fbd62f: [ValueTracking] Clarify TypeSize comparisons

Cullen Rhodes via All-commits all-commits at lists.llvm.org
Fri Oct 16 03:32:14 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fbd62fe60fb2281ca33da35dc25ca3c87ec0bb51
      https://github.com/llvm/llvm-project/commit/fbd62fe60fb2281ca33da35dc25ca3c87ec0bb51
  Author: Cullen Rhodes <cullen.rhodes at arm.com>
  Date:   2020-10-16 (Fri, 16 Oct 2020)

  Changed paths:
    M llvm/lib/Analysis/ValueTracking.cpp

  Log Message:
  -----------
  [ValueTracking] Clarify TypeSize comparisons

TypeSize comparisons using overloaded operators should be replaced by
the new isKnownXY comparators when the operands can be fixed-length or
scalable vectors.

In ValueTracking there are several uses of the overloaded operators in
`isKnownNonZero` and `ComputeMultiple`. In the former we already bail
out on scalable vectors since we currently have no way to represent
DemandedElts, and the latter is operating on scalar integers, so we can
assume fixed-size in both instances.

Reviewed By: david-arm

Differential Revision: https://reviews.llvm.org/D89387




More information about the All-commits mailing list