[all-commits] [llvm/llvm-project] 612111: [mlir][Linalg] Fix TensorConstantOp bufferization ...

Nicolas Vasilache via All-commits all-commits at lists.llvm.org
Tue Oct 13 09:37:44 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6121117484ddd7c5a03b40004a8bba58506ce9d0
      https://github.com/llvm/llvm-project/commit/6121117484ddd7c5a03b40004a8bba58506ce9d0
  Author: Nicolas Vasilache <nicolas.vasilache at gmail.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
    M mlir/integration_test/Dialect/Linalg/CPU/test-tensor-matmul.mlir
    M mlir/lib/Dialect/Linalg/Transforms/TensorsToBuffers.cpp
    M mlir/test/Dialect/Linalg/tensors-to-buffers.mlir

  Log Message:
  -----------
  [mlir][Linalg] Fix TensorConstantOp bufferization in Linalg.

TensorConstantOp bufferization currently uses the vector dialect to store constant data into memory.
Due to natural vector size and alignment properties, this is problematic with n>1-D vectors whose most minor dimension is not naturally aligned.

Instead, this revision linearizes the constant and introduces a linalg.reshape to go back to the desired shape.

Still this is still to be considered a workaround and a better longer term solution will probably involve `llvm.global`.

Differential Revision: https://reviews.llvm.org/D89311




More information about the All-commits mailing list