[all-commits] [llvm/llvm-project] 029290: [lldb/docs] Clarify python/swig version incompatib...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 029290f1a6231507b82981d56c0a0d2b02d508e0
      https://github.com/llvm/llvm-project/commit/029290f1a6231507b82981d56c0a0d2b02d508e0
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-10-07 (Wed, 07 Oct 2020)

  Changed paths:
    M lldb/docs/resources/build.rst

  Log Message:
  -----------
  [lldb/docs] Clarify python/swig version incompatibility

The problematic combo is a debug python>=3.7 && swig<4.0.

Differential Revision: https://reviews.llvm.org/D88906


  Commit: 3dfb94986170c57d9b3f5f2cba039a2eab5e6f13
      https://github.com/llvm/llvm-project/commit/3dfb94986170c57d9b3f5f2cba039a2eab5e6f13
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-10-07 (Wed, 07 Oct 2020)

  Changed paths:
    M lldb/cmake/modules/LLDBGenerateConfig.cmake
    M lldb/include/lldb/Host/Config.h.cmake
    M lldb/include/lldb/Host/PseudoTerminal.h
    M lldb/source/Host/common/ProcessLaunchInfo.cpp
    M lldb/source/Host/common/PseudoTerminal.cpp
    M lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm
    M lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

  Log Message:
  -----------
  [lldb] Check for and use ptsname_r if available

ptsname is not thread-safe. ptsname_r is available on most (but not all)
systems -- use it preferentially.

In the patch I also improve the thread-safety of the ptsname fallback
path by wrapping it in a mutex. This should guarantee the safety of a
typical ptsname implementation using a single static buffer, as long as
all callers go through this function.

I also remove the error arguments, as the only way this function can
fail is if the "primary" fd is not valid. This is a programmer error as
this requirement is documented, and all callers ensure that is the case.

Differential Revision: https://reviews.llvm.org/D88728


Compare: https://github.com/llvm/llvm-project/compare/ce1365f8f7e3...3dfb94986170