[all-commits] [llvm/llvm-project] c74da0: [CMake] Make sure _cmake_system_name has a default

David Tenty via All-commits all-commits at lists.llvm.org
Fri Sep 25 08:33:32 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c74da051b8680d322328a1ba2e6c2ed794a74f59
      https://github.com/llvm/llvm-project/commit/c74da051b8680d322328a1ba2e6c2ed794a74f59
  Author: David Tenty <daltenty at ibm.com>
  Date:   2020-09-25 (Fri, 25 Sep 2020)

  Changed paths:
    M llvm/cmake/modules/LLVMExternalProjectUtils.cmake

  Log Message:
  -----------
  [CMake] Make sure _cmake_system_name has a default

We currently try to pick it up from the CMake arguments passed to llvm_ExternalProject_Add but
if there isn't an explicit option passed, we should reflect CMake's own default behaviour
of targeting the host, since we'll make decisions about what tools to use for the build based on
the setting. Otherwise, we'll get different behaviour between configuring an external project with
the default target and configuring with an explicit one targeting the same platform.

Reviewed By: stevewan, hubert.reinterpretcast

Differential Revision: https://reviews.llvm.org/D88157




More information about the All-commits mailing list