[all-commits] [llvm/llvm-project] 56ffb8: [mlir] Stop allowing LLVMType Int arguments for GP...

[Alexander Belyaev via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 56ffb8d1697932c1097fba3315dba6d9e55b7bb8
      https://github.com/llvm/llvm-project/commit/56ffb8d1697932c1097fba3315dba6d9e55b7bb8
  Author: Alexander Belyaev <pifon at google.com>
  Date:   2020-09-24 (Thu, 24 Sep 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/GPU/GPUOps.td
    M mlir/test/Conversion/GPUCommon/lower-launch-func-to-gpu-runtime-calls.mlir

  Log Message:
  -----------
  [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp.

Conversion to LLVM becomes confusing and incorrect if someone tries to lower
STD -> LLVM and only then GPULaunchFuncOp to LLVM separately. Although it is
technically allowed now, it works incorrectly because of the argument
promotion. The correct way to use this conversion pattern is to add to the
STD->LLVM patterns before running the pass.

Differential Revision: https://reviews.llvm.org/D88147