[all-commits] [llvm/llvm-project] 806984: [MLIR][TableGen] Automatic detection and eliminati...

[Rahul Joshi via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8069844577d47f503cb71644f2e58e0237d5b539
      https://github.com/llvm/llvm-project/commit/8069844577d47f503cb71644f2e58e0237d5b539
  Author: Rahul Joshi <jurahul at google.com>
  Date:   2020-09-17 (Thu, 17 Sep 2020)

  Changed paths:
    M mlir/include/mlir/TableGen/OpClass.h
    M mlir/lib/TableGen/OpClass.cpp
    M mlir/test/mlir-tblgen/op-attribute.td
    M mlir/test/mlir-tblgen/op-result.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [MLIR][TableGen] Automatic detection and elimination of redundant methods

- Change OpClass new method addition to find and eliminate any existing methods that
  are made redundant by the newly added method, as well as detect if the newly added
  method will be redundant and return nullptr in that case.
- To facilitate that, add the notion of resolved and unresolved parameters, where resolved
  parameters have each parameter type known, so that redundancy checks on methods
  with same name but different parameter types can be done.
- Eliminate existing code to avoid adding conflicting/redundant build methods and rely
  on this new mechanism to eliminate conflicting build methods.

Fixes https://bugs.llvm.org/show_bug.cgi?id=47095

Differential Revision: https://reviews.llvm.org/D87059