[all-commits] [llvm/llvm-project] 0dca1a: [llvm-readelf/obj][test] - Document what we print ...

[Georgii Rymar via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0dca1ac617d802c0806f57f67eb830c4f5f3fffb
      https://github.com/llvm/llvm-project/commit/0dca1ac617d802c0806f57f67eb830c4f5f3fffb
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-09-17 (Thu, 17 Sep 2020)

  Changed paths:
    M llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
    M llvm/test/tools/llvm-readobj/ELF/hash-symbols.test
    M llvm/test/tools/llvm-readobj/ELF/mips-got.test
    M llvm/test/tools/llvm-readobj/ELF/mips-plt.test
    M llvm/test/tools/llvm-readobj/ELF/symbol-shndx.test

  Log Message:
  -----------
  [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols.

We have an issue with `ELFDumper<ELFT>::getSymbolSectionName`:
1) It is used deeply for both LLVM/GNU styles and might return LLVM-style only
   values to describe symbols: "Undefined", "Processor Specific", "Absolute", etc.

2) `getSymbolSectionName` is used by `getFullSymbolName` and these special values
   might appear in instead of symbol names in many places.
   This occurs for unnamed section symbols.

It was not noticed because for most cases I've found it is unexpected to have an
unnamed section symbol. This patch documents the existent behavior, adds tests and FIXMEs.

Differential revision: https://reviews.llvm.org/D87763