[all-commits] [llvm/llvm-project] 6b954f: [KillTheDoctor/CMake] Add missing keyword PRIVATE ...

dmm9 via All-commits all-commits at lists.llvm.org
Mon Sep 7 06:09:15 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6b954f1b79605e4139157ce064fe695c86a0f06a
      https://github.com/llvm/llvm-project/commit/6b954f1b79605e4139157ce064fe695c86a0f06a
  Author: Daniel Muñoz <danyable at gmail.com>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M llvm/utils/KillTheDoctor/CMakeLists.txt

  Log Message:
  -----------
  [KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries

Add PRIVATE keyword in target_link_libraries to prevent CMake Error on Windows.

While trying to compile llvm/clang on Windows, the following CMake error occurred. The reason is a missing PUBLIC/PRIVATE/INTERFACE keyword in target_link_libraries.

`
CMake Error at utils/KillTheDoctor/CMakeLists.txt:5 (target_link_libraries):
  The keyword signature for target_link_libraries has already been used with
  the target "KillTheDoctor".  All uses of target_link_libraries with a
  target must be either all-keyword or all-plain.

  The uses of the keyword signature are here:

   * cmake/modules/AddLLVM.cmake:771 (target_link_libraries)
`

Reviewed By: tambre

Differential Revision: https://reviews.llvm.org/D87203




More information about the All-commits mailing list