[all-commits] [llvm/llvm-project] eb87e1: [Asan] Cleanup atomic usage in allocator

Vitaly Buka via All-commits all-commits at lists.llvm.org
Sat Sep 5 19:55:58 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: eb87e1dbcfdf15c0711146ff3e6b2e1e40c8863a
      https://github.com/llvm/llvm-project/commit/eb87e1dbcfdf15c0711146ff3e6b2e1e40c8863a
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2020-09-05 (Sat, 05 Sep 2020)

  Changed paths:
    M compiler-rt/lib/asan/asan_allocator.cpp

  Log Message:
  -----------
  [Asan] Cleanup atomic usage in allocator

There are no know bugs related to this, still it may fix some latent ones.
Main concerns with preexisting code:
1. Inconsistent atomic/non-atomic access to the same field.
2. Assumption that bitfield chunk_state is always the first byte without
    even taking into account endianness.

Reviewed By: morehouse

Differential Revision: https://reviews.llvm.org/D86917




More information about the All-commits mailing list