[all-commits] [llvm/llvm-project] 5ffd94: Reland [FileCheck] Move FileCheck implementation o...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ffd940ac02a8e000691c45a6dc4f69d0198e675
      https://github.com/llvm/llvm-project/commit/5ffd940ac02a8e000691c45a6dc4f69d0198e675
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-09-01 (Tue, 01 Sep 2020)

  Changed paths:
    A llvm/include/llvm/FileCheck/FileCheck.h
    R llvm/include/llvm/Support/FileCheck.h
    M llvm/include/llvm/module.modulemap
    M llvm/lib/CMakeLists.txt
    A llvm/lib/FileCheck/CMakeLists.txt
    A llvm/lib/FileCheck/FileCheck.cpp
    A llvm/lib/FileCheck/FileCheckImpl.h
    M llvm/lib/Support/CMakeLists.txt
    R llvm/lib/Support/FileCheck.cpp
    R llvm/lib/Support/FileCheckImpl.h
    M llvm/unittests/CMakeLists.txt
    M llvm/unittests/CodeGen/GlobalISel/CMakeLists.txt
    M llvm/unittests/CodeGen/GlobalISel/GISelMITest.h
    A llvm/unittests/FileCheck/CMakeLists.txt
    A llvm/unittests/FileCheck/FileCheckTest.cpp
    M llvm/unittests/Support/CMakeLists.txt
    R llvm/unittests/Support/FileCheckTest.cpp
    M llvm/utils/FileCheck/CMakeLists.txt
    M llvm/utils/FileCheck/FileCheck.cpp
    A llvm/utils/gn/secondary/llvm/lib/FileCheck/BUILD.gn
    M llvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn
    M llvm/utils/gn/secondary/llvm/unittests/BUILD.gn
    M llvm/utils/gn/secondary/llvm/unittests/CodeGen/GlobalISel/BUILD.gn
    A llvm/utils/gn/secondary/llvm/unittests/FileCheck/BUILD.gn
    M llvm/utils/gn/secondary/llvm/unittests/Support/BUILD.gn

  Log Message:
  -----------
  Reland [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library

This relands e9a3d1a401b07cbf7b11695637f1b549782a26cd which was originally
missing linking LLVMSupport into LLMVFileCheck which broke the SHARED_LIBS build.

Original summary:

The actual FileCheck logic seems to be implemented in LLVMSupport. I don't see a
good reason for having FileCheck implemented there as it has a very specific use
while LLVMSupport is a dependency of pretty much every LLVM tool there is. In
fact, the only use of FileCheck I could find (outside the FileCheck tool and the
FileCheck unit test) is a single call in GISelMITest.h.

This moves the FileCheck logic to its own LLVMFileCheck library. This way only
FileCheck and the GlobalISelTests now have a dependency on this code.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D86344