[all-commits] [llvm/llvm-project] ca233b: [llvm-readobj][test] - Remove amdgpu-elf-definitio...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Tue Sep 1 04:05:21 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ca233be2f0a6623d835d33f1453d3248448ba606
      https://github.com/llvm/llvm-project/commit/ca233be2f0a6623d835d33f1453d3248448ba606
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-09-01 (Tue, 01 Sep 2020)

  Changed paths:
    R llvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-amdhsa-gfx803
    R llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test

  Log Message:
  -----------
  [llvm-readobj][test] - Remove amdgpu-elf-definitions.test

`amdgpu-elf-definitions.test` is a file that tests
`Format`, 'OS/ABI' and 'Machine' fields printed for EM_AMDGPU.
It uses a precompiled object.

It is not needed to have it, because:
1) We already test formats in `file-header-format.test` + `llvm/unittests/Object/ELFObjectFileTest.cpp`.
2) We test 'OS/ABI' in `file-header-os-abi.test` for all possible values.
3) We test machine types in `file-header-machine-types.test`

In addition we have `amdgpu-elf-headers.test` which tests EM_AMDGPU specific flags. I.e.
it also tests the fact that llvm-readobj/elf are able to dump such objects.

This patch removes the test case and the corresponding binary.

Differential revision: https://reviews.llvm.org/D86774




More information about the All-commits mailing list