[all-commits] [llvm/llvm-project] 0da845: Remove -Wcompound-token-split-by-space from -Wall.

Richard Smith via All-commits all-commits at lists.llvm.org
Mon Aug 31 20:59:44 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0da84535b1e328188efbc1bb697dc7276f9e7d27
      https://github.com/llvm/llvm-project/commit/0da84535b1e328188efbc1bb697dc7276f9e7d27
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-08-31 (Mon, 31 Aug 2020)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/test/Misc/warning-wall.c
    M clang/test/Parser/compound-token-split.cpp

  Log Message:
  -----------
  Remove -Wcompound-token-split-by-space from -Wall.

Use of a linebreak between the `(` and `{` in a GNU statement-expression
appears to be too common to include this warning in -Wall -- this occurs
in some Linux kernel headers, for example.


  Commit: 113861b444610aebd1c05760a3e0ee6284f42211
      https://github.com/llvm/llvm-project/commit/113861b444610aebd1c05760a3e0ee6284f42211
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-08-31 (Mon, 31 Aug 2020)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/lib/Parse/Parser.cpp
    M clang/test/Parser/compound-token-split.cpp

  Log Message:
  -----------
  Fix -Wcompound-token-split to give the same warnings under -E
-frewrite-includes.

Remove the special-case (and highly implausible) diagnostic for a
compound token that crosses a file boundary, and instead model that case
the same as a compound token separated by whitespace, so that file
transitions and presumed file transitions behave the same way.


Compare: https://github.com/llvm/llvm-project/compare/3c7bfbd6831b...113861b44461


More information about the All-commits mailing list