[all-commits] [llvm/llvm-project] 19311f: [lldb] common completion for process pids and proc...

Gongyu Deng via All-commits all-commits at lists.llvm.org
Mon Aug 24 08:31:15 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 19311f5c3e9ada9d445e49feb7a2ae00ddaee2fa
      https://github.com/llvm/llvm-project/commit/19311f5c3e9ada9d445e49feb7a2ae00ddaee2fa
  Author: Gongyu Deng <gy_deng at icloud.com>
  Date:   2020-08-24 (Mon, 24 Aug 2020)

  Changed paths:
    M lldb/include/lldb/Interpreter/CommandCompletions.h
    M lldb/source/Commands/CommandCompletions.cpp
    M lldb/source/Commands/CommandObjectPlatform.cpp
    M lldb/source/Commands/CommandObjectProcess.cpp
    M lldb/source/Interpreter/CommandObject.cpp
    M lldb/test/API/functionalities/completion/TestCompletion.py
    M lldb/test/API/functionalities/completion/main.cpp

  Log Message:
  -----------
  [lldb] common completion for process pids and process names

1. Added two common completions: `ProcessIDs` and `ProcessNames`, which are
refactored from their original dedicated option completions;
2. Removed the dedicated option completion functions of `process attach` and
`platform process attach`, so that they can use arg-type-bound common
completions instead;
3. Bound `eArgTypePid` to the pid completion, `eArgTypeProcessName` to the
process name completion in `CommandObject.cpp`;
4. Added a related test case.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D80700




More information about the All-commits mailing list