[all-commits] [llvm/llvm-project] 7cffaf: [X89] Ignore -mtune=generic to fix failures some u...

topperc via All-commits all-commits at lists.llvm.org
Wed Aug 19 13:18:46 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7cffaf510f97eabef89b0d45aeb939df40e8e9d3
      https://github.com/llvm/llvm-project/commit/7cffaf510f97eabef89b0d45aeb939df40e8e9d3
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-08-19 (Wed, 19 Aug 2020)

  Changed paths:
    M clang/lib/Driver/ToolChains/Clang.cpp

  Log Message:
  -----------
  [X89] Ignore -mtune=generic to fix failures some users are seeing after D85384

Some code bases out there pass -mtune=generic to clang. This would have
been ignored prior to D85384. Now it results in an error
because "generic" isn't recognized by isValidCPUName.

And if we let it go through to the backend as a tune
setting it would get the tune flags closer to i386 rather
than a modern CPU.

I plan to change what tune=generic does in the backend in
a future patch. And allow this in the frontend.
But this should be a quick fix for the error some users
are seeing.




More information about the All-commits mailing list