[all-commits] [llvm/llvm-project] 8351e8: [GlobalISel] Don't skip adding predicate matcher

[Madhur via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8351e80cd17b08ed1a95790eb61fc6f9b7084ba0
      https://github.com/llvm/llvm-project/commit/8351e80cd17b08ed1a95790eb61fc6f9b7084ba0
  Author: madhur13490 <Madhur.Amilkanthwar at amd.com>
  Date:   2020-08-19 (Wed, 19 Aug 2020)

  Changed paths:
    A llvm/test/TableGen/ContextlessPredicates.td
    M llvm/utils/TableGen/GlobalISelEmitter.cpp

  Log Message:
  -----------
  [GlobalISel] Don't skip adding predicate matcher

This patch fixes a bug which skipped
adding predicate matcher for a pattern in many cases.
For example, if predicate is Load and
its memoryVT is non-null then the loop
continues and never reaches to the end which
adds the predicate matcher. This patch moves the
matcher addition to the top of the loop
so that it gets added regardless of contextual checks
later in the loop.
Other way to fix this issue is to remove all "continue" statements
in checks and let the loop continue till end.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D83034