[all-commits] [llvm/llvm-project] 24c3da: DebugInfo: Emit class template parameters first, b...

[David Blaikie via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 24c3dabef4436ec6436fb80e0672577ec52159ba
      https://github.com/llvm/llvm-project/commit/24c3dabef4436ec6436fb80e0672577ec52159ba
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    M llvm/test/DebugInfo/Generic/template-recursive-void.ll

  Log Message:
  -----------
  DebugInfo: Emit class template parameters first, before members

This reads more like what you'd expect the DWARF to look like (from the
lexical order of C++ - template parameters come before members, etc),
and also happens to make it easier to tickle (& thus test) a bug related
to type units and Split DWARF I'm about to fix.


  Commit: be3ef93bf58aa5546c7baadfb21d43b75fbb4e24
      https://github.com/llvm/llvm-project/commit/be3ef93bf58aa5546c7baadfb21d43b75fbb4e24
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/AddressPool.h
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
    A llvm/test/DebugInfo/X86/addr-tu-to-non-tu.ll

  Log Message:
  -----------
  PR44685: DebugInfo: Handle address-use-invalid type units referencing non-type units

Theory was that we should never reach a non-type unit (eg: type in an
anonymous namespace) when we're already in the invalid "encountered an
address-use, so stop emitting types for now, until we throw out the
whole type tree to restart emitting in non-type unit" state. But that's
not the case (prior commit cleaned up one reason this wasn't exposed
sooner - but also makes it easier to test/demonstrate this issue)


Compare: https://github.com/llvm/llvm-project/compare/8abd69aa9e8c...be3ef93bf58a