[all-commits] [llvm/llvm-project] ab7151: [X86] Make PreprocessISelDAG create X86ISD::VRNDSC...

topperc via All-commits all-commits at lists.llvm.org
Mon Aug 17 17:26:52 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ab7151f1cff7b028be70d9c97181989949680f5d
      https://github.com/llvm/llvm-project/commit/ab7151f1cff7b028be70d9c97181989949680f5d
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelDAGToDAG.cpp

  Log Message:
  -----------
  [X86] Make PreprocessISelDAG create X86ISD::VRNDSCALE nodes with i32 constants instead of i8.

This is the type declared in X86InstrFragmentsSIMD.td. ISel pattern
matching doesn't check so it doesn't matter in practice. Maybe for
SelectionDAG CSE it would matter.


  Commit: bc244f08cf5129f99fe6f7f76a373463f07e7c84
      https://github.com/llvm/llvm-project/commit/bc244f08cf5129f99fe6f7f76a373463f07e7c84
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Truncate immediate to i8 for INTR_TYPE_3OP_IMM8

This is used for DBPSADBW which has a i32 immediate for its
intrinsic and an i8 immediate in tablegen isel patterns.


  Commit: 2ffa5d218f959ffbacf48f989b318bf68bb550f1
      https://github.com/llvm/llvm-project/commit/2ffa5d218f959ffbacf48f989b318bf68bb550f1
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/Target/X86/X86IntrinsicsInfo.h

  Log Message:
  -----------
  [X86] Rename INTR_TYPE_4OP to INTR_TYPE_4OP_IMM8 and truncate immediates to MVT::i8

This makes sure VPTERNLOG is generated with MVT::i8 immediate
as its SDNode declaration in X86InstrFragmentsSIMD.td declares.


  Commit: b673dfbb9a0e6b3c27917e3097b19235883d606e
      https://github.com/llvm/llvm-project/commit/b673dfbb9a0e6b3c27917e3097b19235883d606e
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] When manually creating intrinsic nodes in X86ISelLowering, make sure we use getTargetConstant and pointer type for the intrinsic ID.

Doesn't really matter in practice but that's how the nodes are
normally created by SelectionDAGBuilder. So we should match.

Found by temporarily hacking type checks into isel table.


Compare: https://github.com/llvm/llvm-project/compare/d0e2c79b61a1...b673dfbb9a0e


More information about the All-commits mailing list