[all-commits] [llvm/llvm-project] 24c74f: [lldb] Don't delete orphaned shared modules in SBD...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Mon Aug 17 02:31:31 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 24c74f5e8c2cf263dd84292ca5d33ee0890b48dd
      https://github.com/llvm/llvm-project/commit/24c74f5e8c2cf263dd84292ca5d33ee0890b48dd
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M lldb/source/API/SBDebugger.cpp

  Log Message:
  -----------
  [lldb] Don't delete orphaned shared modules in SBDebugger::DeleteTarget

In D83876 the consensus seems that LLDB should never deleted orphaned modules
implicitly. However, SBDebugger::DeleteTarget is currently doing exactly that.
This code was added in 753406221b55b95141c8c1239660dc4db4e35ea5 but I don't see
any explanation in the commit, so I think we should delete it.

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D83933




More information about the All-commits mailing list